Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.28%. Comparing base (33f9894) to head (7f5eb4c).
⚠️ Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   99.27%   99.28%           
=======================================
  Files          94       94           
  Lines        5092     5116   +24     
=======================================
+ Hits         5055     5079   +24     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LGTM! Do we also want this in 1D?

My main motivation to introduce this dissipation term was to enable a well-balanced formulation with node-wise limiting (which is only implemented in 2D right now).

We can also add this in 1D, but for the currently available volume integrals we can also always use hydrostatic reconstruction + standard LLF dissipation, so its more optional.

LGTM! Do we also want this in 1D?

My main motivation to introduce this dissipation term was to enable a well-balanced formulation with node-wise limiting (which is only implemented in 2D right now).

We can also add this in 1D, but for the currently available volume integrals we can also always use hydrostatic reconstruction + standard LLF dissipation, so its more optional.

Ah, gotcha. Then there is no need to do this is 1D as it would be unnecessary. I will approve this